Separately run macOS tests to avoid failures due to lack of Docker #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore flaky `testMultipleClientParallel`
…t client and server
…t client and server
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the test infrastructure to use Docker containers for running TypeScript SDK tests, specifically addressing Docker compatibility issues on macOS by separating test execution into platform-specific jobs.
- Replaces local TypeScript SDK cloning and process execution with Docker-based test runners
- Updates CI workflow to run macOS tests separately from Docker-based JVM tests
- Refactors test utilities to use testcontainers library for better container management
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| kotlin-sdk-test/src/jvmTest/kotlin/io/modelcontextprotocol/kotlin/sdk/integration/utils/Dockerfile | Adds Docker image definition for TypeScript SDK test environment |
| kotlin-sdk-test/src/jvmTest/kotlin/io/modelcontextprotocol/kotlin/sdk/integration/typescript/TsTestBase.kt | Major refactor replacing local process execution with Docker container management |
| kotlin-sdk-test/src/jvmTest/kotlin/io/modelcontextprotocol/kotlin/sdk/integration/typescript/sse/*.kt | Updates test classes to use new Docker-based infrastructure |
| kotlin-sdk-test/build.gradle.kts | Adds testcontainers dependency |
| gradle/libs.versions.toml | Adds testcontainers library version |
| .github/workflows/build.yml | Splits CI into separate macOS and Ubuntu jobs with different test strategies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...t/kotlin/io/modelcontextprotocol/kotlin/sdk/integration/typescript/sse/TsEdgeCasesTestSse.kt
Show resolved
Hide resolved
...t/src/jvmTest/kotlin/io/modelcontextprotocol/kotlin/sdk/integration/typescript/TsTestBase.kt
Show resolved
Hide resolved
...t/src/jvmTest/kotlin/io/modelcontextprotocol/kotlin/sdk/integration/typescript/TsTestBase.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context